fix: temporary disable animation #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable animations for all charts until we fix elastic#89 and elastic#41 and until we found a right strategy for animate everything nicely and at 60fps. fix elastic#161
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 96.26% 96.26% +<.01%
==========================================
Files 36 36
Lines 1848 1849 +1
Branches 239 239
==========================================
+ Hits 1779 1780 +1
Misses 60 60
Partials 9 9
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 3.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
emmacunningham
pushed a commit
to emmacunningham/elastic-charts
that referenced
this pull request
Apr 11, 2019
Disable animations for all charts until we fix elastic#89 and elastic#41 and until we found a right strategy for animate everything nicely and at 60fps. fix elastic#161
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [3.10.1](elastic/elastic-charts@v3.10.0...v3.10.1) (2019-04-11) ### Bug Fixes * temporary disable animation ([opensearch-project#164](elastic/elastic-charts#164)) ([0d12878](elastic/elastic-charts@0d12878)), closes [opensearch-project#89](elastic/elastic-charts#89) [opensearch-project#41](elastic/elastic-charts#41) [opensearch-project#161](elastic/elastic-charts#161) * temporary disable animation ([opensearch-project#164](elastic/elastic-charts#164)) ([76ab583](elastic/elastic-charts@76ab583)), closes [opensearch-project#89](elastic/elastic-charts#89) [opensearch-project#41](elastic/elastic-charts#41) [opensearch-project#161](elastic/elastic-charts#161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disable animations for all charts until we fix #89 and #41 and until we found a right strategy for
animate everything nicely and at 60fps.
fix #161
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Proper documentation or storybook story was added for features that require explanation or tutorials[ ] Unit tests were updated or added to match the most common scenarios