fix(crosshair): use offsetX/Y instead of clientX/Y #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit correct the behaviour of using clientX and clientY instead of offsetX and offsetY. The previous behavious used the synthetic position of the mouse cursor, this commit change it to use the native event value that already take care of the border box. fix elastic#123
emmacunningham
approved these changes
Mar 27, 2019
|
🎉 This PR is included in version 3.4.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [3.4.4](elastic/elastic-charts@v3.4.3...v3.4.4) (2019-03-28) ### Bug Fixes * **crosshair:** use offsetX/Y instead of clientX/Y ([opensearch-project#128](elastic/elastic-charts#128)) ([ce2cd17](elastic/elastic-charts@ce2cd17)), closes [opensearch-project#123](elastic/elastic-charts#123)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit correct the behaviour of using clientX and clientY instead of offsetX and offsetY. The
previous behavious used the synthetic position of the mouse cursor, this commit change it to use the
native event value that already take care of the border box.
fix #123
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.