Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crosshair works incorrectly after page scroll #123

Closed
2 tasks done
sulemanof opened this issue Mar 27, 2019 · 2 comments · Fixed by #128 or #1314
Closed
2 tasks done

Crosshair works incorrectly after page scroll #123

sulemanof opened this issue Mar 27, 2019 · 2 comments · Fixed by #128 or #1314
Assignees
@markov00
Labels
bug Something isn't working :interactions Interactions related issue released Issue released publicly

Comments

@sulemanof
Copy link

sulemanof commented Mar 27, 2019 •
edited by markov00
Loading

Describe the bug
Crosshair works incorrectly after page scroll. User unable to see a tooltip while hover on a chart point

To Reproduce
Steps to reproduce the behavior:

  1. Create any chart with data
  2. Hover on any point -> user is able to see a tooltip
  3. Scroll down a bit
  4. Hover on any point -> user can't see any tooltip
  5. Move the mouse down on the same tick -> in one moment the tooltip will appear as on point hover

Expected behavior
A page scroll shouldn't break the chart positioning

Screenshots
chart_scroll_issue

Version (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome 73
  • Elastic Charts: 3.4.0

Additional context
n/a

Errors in browser console
n/a

Kibana Cross Issues
n/a

Checklist

  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@sulemanof sulemanof added the bug Something isn't working label Mar 27, 2019
@markov00 markov00 self-assigned this Mar 27, 2019
@markov00 markov00 added the :interactions Interactions related issue label Mar 27, 2019
@markov00 markov00 added this to the 7.1 milestone Mar 27, 2019
markov00 added a commit to markov00/elastic-charts that referenced this issue Mar 27, 2019
@markov00
fix(crosshair): use offsetX/Y instead of clientX/Y
0c55022 
This commit correct the behaviour of using clientX and clientY instead of offsetX and offsetY. The
previous behavious used the synthetic position of the mouse cursor, this commit change it to use the
native event value that already take care of the border box.

fix elastic#123
@markov00 markov00 mentioned this issue Mar 27, 2019
Merged
4 tasks
markov00 added a commit that referenced this issue Mar 28, 2019
@markov00
fix(crosshair): use offsetX/Y instead of clientX/Y (#128)
7c1155f 
This commit correct the behaviour of using clientX and clientY instead of offsetX and offsetY. The
previous behavious used the synthetic position of the mouse cursor, this commit change it to use the
native event value that already take care of the border box.

fix #123
markov00 pushed a commit that referenced this issue Mar 28, 2019
@semantic-release-bot
chore(release): 3.4.4 [skip ci]
28a0c12 
## [3.4.4](v3.4.3...v3.4.4) (2019-03-28)

### Bug Fixes

* **crosshair:** use offsetX/Y instead of clientX/Y ([#128](#128)) ([7c1155f](7c1155f)), closes [#123](#123)
@markov00
Copy link
Member

🎉 This issue has been resolved in version 3.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Mar 28, 2019
@nickofthyme nickofthyme mentioned this issue Aug 19, 2021
Merged
9 tasks
@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 34.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme mentioned this issue Aug 20, 2021
Closed
9 tasks
This was referenced Aug 23, 2021
Merged
Merged
@markov00 markov00 mentioned this issue Aug 24, 2021
Merged
6 tasks
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 3.4.4 [skip ci]
b672344 
## [3.4.4](elastic/elastic-charts@v3.4.3...v3.4.4) (2019-03-28)

### Bug Fixes

* **crosshair:** use offsetX/Y instead of clientX/Y ([opensearch-project#128](elastic/elastic-charts#128)) ([ce2cd17](elastic/elastic-charts@ce2cd17)), closes [opensearch-project#123](elastic/elastic-charts#123)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
bug Something isn't working :interactions Interactions related issue released Issue released publicly
Projects
None yet
Milestone
No milestone
3 participants
@markov00 @nickofthyme @sulemanof