Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessible goal chart (numbers and strings) #1160

Closed
myasonik opened this issue May 14, 2021 · 1 comment · Fixed by #1174
Closed

Accessible goal chart (numbers and strings) #1160

myasonik opened this issue May 14, 2021 · 1 comment · Fixed by #1174
Assignees
@rshen91
Labels
:accessibility Accessibility related issue enhancement New feature or request :goal/gauge (old) Old Goal/Gauge chart related issues released Issue released publicly

Comments

@myasonik
Copy link

Goals have few data points:

  • min
  • max
  • target
  • value
  • label major
  • label minor

min, max, target, and value we should incorporate into the <dl>

The major label should be incorporated into the accessible labels for the chart
@myasonik myasonik added bug Something isn't working :accessibility Accessibility related issue labels May 14, 2021
@markov00 markov00 added enhancement New feature or request and removed bug Something isn't working labels May 26, 2021
@rshen91 rshen91 self-assigned this May 27, 2021
@rshen91 rshen91 mentioned this issue May 27, 2021
Merged
1 task
@markov00 markov00 added the :goal/gauge (old) Old Goal/Gauge chart related issues label Jun 12, 2021
rshen91 added a commit that referenced this issue Jun 30, 2021
@rshen91
feat(a11y): accessible goal and gauge chart (#1174)
ffa8822 
Fixes #1160
nickofthyme pushed a commit that referenced this issue Jul 6, 2021
@semantic-release-bot
chore(release): 31.1.0 [skip ci]
f8a7111 
# [31.1.0](v31.0.0...v31.1.0) (2021-07-06)

### Bug Fixes

* **heatmap:** pick correct brush end value ([#1230](#1230)) ([57678fe](57678fe)), closes [#1229](#1229)

### Features

* **a11y:** accessible goal and gauge chart ([#1174](#1174)) ([ffa8822](ffa8822)), closes [#1160](#1160)
@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 31.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Jul 6, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 31.1.0 [skip ci]
ad6591f 
# [31.1.0](elastic/elastic-charts@v31.0.0...v31.1.0) (2021-07-06)

### Bug Fixes

* **heatmap:** pick correct brush end value ([opensearch-project#1230](elastic/elastic-charts#1230)) ([cb95a75](elastic/elastic-charts@cb95a75)), closes [opensearch-project#1229](elastic/elastic-charts#1229)

### Features

* **a11y:** accessible goal and gauge chart ([#1174](elastic/elastic-charts#1174)) ([775dc98](elastic/elastic-charts@775dc98)), closes [opensearch-project#1160](elastic/elastic-charts#1160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rshen91 rshen91

Labels
:accessibility Accessibility related issue enhancement New feature or request :goal/gauge (old) Old Goal/Gauge chart related issues released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(a11y): accessible goal and gauge chart rshen91/elastic-charts
4 participants
@markov00 @myasonik @nickofthyme @rshen91