fix: vrt errors with empty blocks and icon loading lag

elastic · Dec 4, 2020 · c2f02e1 · c2f02e1
1 parent 89035d3
commit c2f02e1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -256,6 +256,7 @@ module.exports = {
     'unicorn/prefer-node-append': 0,
     'unicorn/no-zero-fractions': 0,
     'unicorn/prefer-node-remove': 0, // not IE11 compatible
+    'unicorn/no-unreadable-array-destructuring': 0,
     'unicorn/filename-case': [
       'error',
       {

diff --git a/integration/helpers.ts b/integration/helpers.ts
@@ -102,6 +102,7 @@ export function getStorybookInfo(): StoryGroupInfo[] {
 
       const encodedGroup = encodeString(group);
 
-      return [group, encodedGroup, stories];
-    });
+      return [group, encodedGroup, stories] as StoryGroupInfo;
+    })
+    .filter(([, , stories]) => stories.length > 0);
 }
diff --git a/integration/tests/test_cases_stories.test.ts b/integration/tests/test_cases_stories.test.ts
@@ -24,8 +24,7 @@ describe('Test cases stories', () => {
     await common.expectChartAtUrlToMatchScreenshot(
       'http://localhost:9001/?path=/story/test-cases--no-series&knob-Show custom no results=true',
       {
-        waitSelector: '.echReactiveChart_noResults',
-        delay: 500, // needed for icon to load
+        waitSelector: '.echReactiveChart_noResults .euiIcon:not(.euiIcon-isLoading)',
       },
     );
   });