refactor: add comments and remove unnecessary type

elastic · Apr 10, 2019 · 8e0bfe7 · 8e0bfe7
1 parent 4c155fa
commit 8e0bfe7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/lib/series/rendering.ts b/src/lib/series/rendering.ts
@@ -165,9 +165,11 @@ export function renderBars(
   const barGeometries: BarGeometry[] = [];
   dataset.forEach((datum) => {
     const { y0, y1, initialY1 } = datum;
+    // don't create a bar if the initialY1 value is null.
     if (initialY1 === null) {
       return;
     }
+    // don't create a bar if the x value is not part of the ordinal scale
     if (xScaleType === ScaleType.Ordinal && !xDomain.includes(datum.x)) {
       return;
     }

diff --git a/src/lib/series/series.ts b/src/lib/series/series.ts
@@ -344,7 +344,7 @@ export function formatStackedDataSeriesValues(
   dataseries: RawDataSeries[],
   scaleToExtent: boolean,
 ): DataSeries[] {
-  const yValueStackMap: Map<any, number[]> = getYValueStackMap(dataseries);
+  const yValueStackMap = getYValueStackMap(dataseries);
 
   const stackedValues = computeYStackedMapValues(yValueStackMap, scaleToExtent);