refactor: change config prop name to show vs enable

elastic · Mar 17, 2020 · 6ba6751 · 6ba6751
1 parent 55bf6ee
commit 6ba6751
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 10 deletions.
diff --git a/src/chart_types/xy_chart/utils/axis_utils.test.ts b/src/chart_types/xy_chart/utils/axis_utils.test.ts
@@ -1449,7 +1449,7 @@ describe('Axis computational utils', () => {
     const axisSpec: AxisSpec = {
       id: 'bottom',
       position: 'bottom',
-      enableDuplicatedTicks: false,
+      showDuplicatedTicks: false,
       chartType: 'xy_axis',
       specType: 'axis',
       groupId: '__global__',
@@ -1489,7 +1489,7 @@ describe('Axis computational utils', () => {
     const axisSpec: AxisSpec = {
       id: 'bottom',
       position: 'bottom',
-      enableDuplicatedTicks: true,
+      showDuplicatedTicks: true,
       chartType: 'xy_axis',
       specType: 'axis',
       groupId: '__global__',

diff --git a/src/chart_types/xy_chart/utils/axis_utils.ts b/src/chart_types/xy_chart/utils/axis_utils.ts
@@ -458,7 +458,7 @@ export function enableDuplicatedTicks(
     };
   });
 
-  if (axisSpec.enableDuplicatedTicks === true) {
+  if (axisSpec.showDuplicatedTicks === true) {
     return allTicks;
   }
 

diff --git a/src/chart_types/xy_chart/utils/specs.ts b/src/chart_types/xy_chart/utils/specs.ts
@@ -526,7 +526,7 @@ export interface AxisSpec extends Spec {
   /** Show only integar values **/
   integersOnly?: boolean;
   /** Remove duplicate ticks, default is false*/
-  enableDuplicatedTicks?: boolean;
+  showDuplicatedTicks?: boolean;
 }
 
 export type TickFormatterOptions = {

diff --git a/stories/line/10_duplicate_ticks.tsx b/stories/line/10_duplicate_ticks.tsx
@@ -32,12 +32,7 @@ export const example = () => {
   const duplicateTicksInAxis = boolean('Show duplicate ticks in x axis', false);
   return (
     <Chart className="story-chart">
-      <Axis
-        id="bottom"
-        position={Position.Bottom}
-        tickFormat={formatter}
-        enableDuplicatedTicks={duplicateTicksInAxis}
-      />
+      <Axis id="bottom" position={Position.Bottom} tickFormat={formatter} showDuplicatedTicks={duplicateTicksInAxis} />
       <Axis
         id="left"
         title={KIBANA_METRICS.metrics.kibana_os_load[0].metric.title}