refactor(geometry): add GEOMETRY_STYLES constant

elastic · Feb 8, 2019 · 409097e · 409097e
1 parent c062b2e
commit 409097e
Showing 1 changed file with 14 additions and 5 deletions.
diff --git a/src/lib/series/rendering.ts b/src/lib/series/rendering.ts
@@ -181,14 +181,23 @@ export function getGeometryStyle(
   geometryId: GeometryId,
   highlightedLegendItem: LegendItem | null,
 ): GeometryStyle {
-  let opacity = 1;
   if (highlightedLegendItem != null) {
     const isPartOfHighlightedSeries = belongsToDataSeries(geometryId, highlightedLegendItem.value);
 
-    if (!isPartOfHighlightedSeries) {
-      opacity = 0.25;
-    }
+    return isPartOfHighlightedSeries ? GEOMETRY_STYLES.highlighted : GEOMETRY_STYLES.unhighlighted;
   }
 
-  return { opacity };
+  return GEOMETRY_STYLES.default;
 }
+
+const GEOMETRY_STYLES: { [key: string]: GeometryStyle } = {
+  default: {
+    opacity: 1,
+  },
+  highlighted: {
+    opacity: 1,
+  },
+  unhighlighted: {
+    opacity: 0.25,
+  },
+};