Skip to content

Commit

Permalink
feat(partition): small multiples (#1076)
Browse files Browse the repository at this point in the history
Adds small multiples for partition charts; in the current alpha, primarily sunburst.

BREAKING CHANGE: clarifies the inner/outer padding notation `<SmallMultiples style={{horizontalPanelPadding, verticalPanelPadding}}` from `[outer, inner]` to `{outer, inner}`—they still have the same effect
  • Loading branch information
monfera authored Mar 23, 2021
1 parent 112497b commit 282082b
Show file tree
Hide file tree
Showing 53 changed files with 3,482 additions and 2,801 deletions.
16 changes: 12 additions & 4 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,17 @@ module.exports = {
: 0,
'import/namespace': process.env.NODE_ENV === 'production' ? 2 : 0,

/**
**************************************************************
* Rules that ensure sufficient freedom of expressing intent
**************************************************************
*/
'no-else-return': 'off',
'no-param-reassign': [1, { props: false }],
'@typescript-eslint/comma-spacing': 0,
'unicorn/no-nested-ternary': 0,
'@typescript-eslint/lines-between-class-members': ['error', 'always', { exceptAfterSingleLine: true }],

/**
*****************************************
* Rules to consider adding/fixing later
Expand All @@ -81,8 +92,6 @@ module.exports = {
'global-require': 1,
'import/no-dynamic-require': 1,
'no-shadow': 1,
'no-param-reassign': [1, { props: false }],
'@typescript-eslint/comma-spacing': 0,
'react/no-array-index-key': 1,
'react/prefer-stateless-function': 1,
'react/require-default-props': 'off',
Expand All @@ -92,7 +101,6 @@ module.exports = {
'jsx-a11y/click-events-have-key-events': 1,
'@typescript-eslint/member-ordering': 1,
eqeqeq: 1,
'unicorn/no-nested-ternary': 0,

/**
* Standard rules
Expand All @@ -107,7 +115,6 @@ module.exports = {
'no-bitwise': 0,
'no-void': 0,
yoda: 0,
'@typescript-eslint/lines-between-class-members': ['error', 'always', { exceptAfterSingleLine: true }],
'no-restricted-globals': 0,
'no-case-declarations': 0,
'no-return-await': 0,
Expand Down Expand Up @@ -255,6 +262,7 @@ module.exports = {
'unicorn/no-null': 0,
'unicorn/no-fn-reference-in-iterator': 0,
'unicorn/prefer-query-selector': 0,
'unicorn/prefer-array-find': 0,
'unicorn/no-for-loop': 0,
'unicorn/no-reduce': 0,
'unicorn/no-useless-undefined': 0,
Expand Down
2 changes: 1 addition & 1 deletion .playground/playground.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

import React from 'react';

import { Example } from '../stories/wordcloud/1_wordcloud';
import { Example } from '../stories/small_multiples/7_sunbursts';

export class Playground extends React.Component {
render() {
Expand Down
Loading

0 comments on commit 282082b

Please sign in to comment.