-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config generation benchmark #6180
Conversation
7ec41a2
to
bc3a83d
Compare
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
bc3a83d
to
e004ea1
Compare
e004ea1
to
d132329
Compare
d132329
to
a20b23c
Compare
Needless to say, the unit test failure is unrelated, though it seems strangely consistent in this PR. Looks like a repeated instance of #5938. |
a20b23c
to
a2ed4fa
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
(cherry picked from commit b3bb590) # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_test.go
(cherry picked from commit b3bb590)
(cherry picked from commit b3bb590) # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_test.go
(cherry picked from commit b3bb590) # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_test.go
(cherry picked from commit b3bb590) # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_test.go
(cherry picked from commit b3bb590) # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_test.go
(cherry picked from commit b3bb590) Co-authored-by: Mikołaj Świątek <[email protected]>
(cherry picked from commit b3bb590) # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_test.go Co-authored-by: Mikołaj Świątek <[email protected]>
(cherry picked from commit b3bb590) # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_test.go
(cherry picked from commit b3bb590) # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_test.go Co-authored-by: Mikołaj Świątek <[email protected]>
What does this PR do?
Add a benchmark for config generation in the coordinator. We specifically profile having a lot of Pods from the Kubernetes provider, which is something that has recently become a problem, and which the configuration generation pipeline doesn't deal with very well. I used test data from a real environment where the problems outlined in #5991 and #5835 could be reproduced.
From profiling the live agent experiencing these issues, this benchmark covers the most expensive parts, so it should be representative.
Current results on
main
:Why is it important?
I'd like to make some improvements to the configuration generation in the coordinator, and want a straightforward way of demonstrating their impact.
Checklist
Related issues