[8.16](backport #5999) Add failureThreshold to elastic-agent self-monitoring config #6105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
requested review from
michel-laterman and
swiatekm
and removed request for
a team
pchila
requested review from
pchila
and removed request for
michel-laterman and
swiatekm
|
buildkite test this |
|
This pull request has not been merged yet. Could you please review and merge it @pchila? 🙏 |
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
@Mergifyio rebase |
* Add failureThreshold to elastic-agent self-monitoring config (cherry picked from commit 2a46509)
pchila
force-pushed
the
mergify/bp/8.16/pr-5999
branch
from
6f2fa1d to
a567a90
Compare
✅ Branch has been successfully rebased |
|
pchila
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use
failure_thresholdintroduced in elastic/beats#41570 in self-monitoring configuration to avoid elastic-agent reporting DEGRADED if it fails to fetch metrics due to a component starting/stopping.The default value for the failure threshold is set to 2 but it can be configured via config file or fleet policy.
Why is it important?
It is important to avoid a misrepresentation of agent status due to a single metrics fetch erroring out once.
See #5332
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself
This is an automatic backport of pull request #5999 done by [Mergify](https://mergify.com).