Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #5302) Call fleet-server audit/unenroll endpoint on uninstall #5688

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 3, 2024

What does this PR do?

Uninstalling a fleet-managed elastic-agent instance will now do a best-effort attempt to notify fleet-server of the agent removal so the agent may not appear as offiline in the UI.

Requires fleet-server PR elastic/fleet-server#3818 to be merged in order for integration tests to succeed.

Why is it important?

Uninstalling the agent leaves inactive (offline) entries in the UI that clutter up the list.
This is an attempt to treat these agents similarly to agents that are unenrolled.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

No disruptive impact, the change is a best-effort api call.

How to test this PR locally

TODO

Related issues


This is an automatic backport of pull request #5302 done by [Mergify](https://mergify.com).

* Call fleet-server audit/unenroll endpoint on uninstall

Uninstalling a fleet-managed elastic-agent instance will now do a
best-effort attempt to notify fleet-server of the agent removal so the
agent may not appear as offiline.

---------

Co-authored-by: Paolo Chilà <[email protected]>
Co-authored-by: Blake Rouse <[email protected]>
(cherry picked from commit 07c2a92)
@mergify mergify bot requested a review from a team as a code owner October 3, 2024 17:03
@mergify mergify bot added the backport label Oct 3, 2024
@mergify mergify bot requested review from blakerouse and michel-laterman and removed request for a team October 3, 2024 17:03
@michel-laterman
Copy link
Contributor

buildkite test this

@jlind23 jlind23 merged commit aded4a7 into 8.x Oct 4, 2024
15 checks passed
@jlind23 jlind23 deleted the mergify/bp/8.x/pr-5302 branch October 4, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants