Revert changes requiring CGO and disable CGO for linting on darwin #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @kvch? 🙏
NOTE: |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
kvch
changed the title
ph
approved these changes
May 18, 2022
v1v
added a commit
to v1v/elastic-agent
that referenced
this pull request
May 19, 2022
…use-orka * 'main' of github.com:elastic/elastic-agent: Initialize logger directory to allow group access (elastic#433) Revert changes requiring CGO and disable CGO for linting on darwin (elastic#441) [Automation] Update elastic stack version to 8.3.0-a55286cc for testing (elastic#447) Documentation enhancements in order to build elastic agent (elastic#442)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR reverts the CGO changes introduced in #344
It includes removing the GH action on
macosand movin the metrics setup toelastic-agent-system-metrics.Why is it important?
Avoid dependency on CGO in the build.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.