Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update prevention condition to allow install if runtime cannot discover the native architecture #4396

Merged
merged 1 commit into from
Mar 11, 2024
Merged

update prevention condition to allow install if runtime cannot discover the native architecture #4396

merged 1 commit into from
Mar 11, 2024

Conversation

intxgo
Copy link
Contributor

@intxgo intxgo commented Mar 11, 2024 •
edited
Loading

What does this PR do?

go-sysinfo cannot read the underlaying native architecture on older Windows OS, before IsWow64Process2 API was introduced. elastic/go-sysinfo#201
We treat this as an unknown architecture, rather that an error. Code depending on the native architecture has to account for the unknown.

Why is it important?

Due to the bug Elastic Defend cannot be installed on Windows 2016, AMD64.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Author's Checklist

  • tested locally on Windows 2016

How to test this PR locally

Install Agent on Windows Server 2016, AMD64. Enroll Agent to a policy with Elastic Defend.

Related issues

Use cases

Screenshots

Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@intxgo intxgo added bug Something isn't working backport-v8.13.0 Automated backport with mergify labels Mar 11, 2024
@intxgo intxgo requested a review from a team as a code owner March 11, 2024 12:39
@intxgo intxgo requested review from ycombinator and leehinman March 11, 2024 12:39
@mergify mergify bot assigned intxgo Mar 11, 2024
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Mar 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@intxgo intxgo merged commit 5d862e2 into elastic:main Mar 11, 2024
10 of 13 checks passed
@intxgo intxgo deleted the update-endpoint-security-spec branch March 11, 2024 20:40
mergify bot pushed a commit that referenced this pull request Mar 11, 2024
@intxgo @mergify
update prevention condtion to allow install if runtime cannot discove…
9ea6dfa 
…r the native architecture (#4396)

(cherry picked from commit 5d862e2)
@mergify mergify bot mentioned this pull request Mar 11, 2024
Merged
pierrehilbert pushed a commit that referenced this pull request Mar 12, 2024
@mergify @intxgo
update prevention condtion to allow install if runtime cannot discove…
ed61c80 
…r the native architecture (#4396) (#4399)

(cherry picked from commit 5d862e2)

Co-authored-by: Leszek Kubik <[email protected]>
@cmacknz cmacknz mentioned this pull request Nov 20, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@ycombinator ycombinator Awaiting requested review from ycombinator ycombinator is a code owner automatically assigned from elastic/elastic-agent-control-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@intxgo intxgo

Labels
backport-v8.13.0 Automated backport with mergify bug Something isn't working skip-changelog Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AMD64 error is displayed when Elastic Defend added to Windows 2012 R2.
4 participants
@intxgo @elasticmachine @cmacknz @pierrehilbert