Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VCS errors in daily serverless tests #3924

Merged

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Dec 18, 2023

This fixes an issue where the tests were failing with an error obtaining VCS status: exit status 128 message. Turns out that something in a newer go version doesn't like our --filter=tree:0 flag we were passing to git.

Technically that's the only part of this required to fix things, the shuffling around of directory setup is to deal with the other circumstances where we might get the same VCS error.

@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

Copy link
Contributor

mergify bot commented Dec 18, 2023

This pull request does not have a backport label. Could you fix it @fearful-symmetry? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@pierrehilbert pierrehilbert merged commit cc81e4b into elastic:main Dec 19, 2023
9 checks passed

git clone --filter=tree:0 [email protected]:elastic/beats.git
cd ..
git clone [email protected]:elastic/beats.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might help if we do shallow clone

Suggested change
git clone [email protected]:elastic/beats.git
git clone --depth=1 [email protected]:elastic/beats.git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants