Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Feature] Start/stop monitoring server based on monitoring config" #3583

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

michalpristas
Copy link
Contributor

Reverts #3492

due to cloud scenario where they have disabled monitoring but expect server to be running

@michalpristas michalpristas added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team backport-skip labels Oct 11, 2023
@michalpristas michalpristas self-assigned this Oct 11, 2023
@michalpristas michalpristas requested a review from a team as a code owner October 11, 2023 07:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@pierrehilbert
Copy link
Contributor

Don't forget to reopen the issue please

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-11T07:48:37.989+0000

  • Duration: 28 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 6489
Skipped 59
Total 6548

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.78% (81/82) 👎 -0.015
Files 67.003% (199/297) 👎 -0.111
Classes 65.642% (363/553) 👎 -0.124
Methods 52.974% (1149/2169) 👎 -0.059
Lines 38.581% (13135/34045) 👎 -0.024
Conditionals 100.0% (0/0) 💚

@elastic-sonarqube
Copy link

@cmacknz
Copy link
Member

cmacknz commented Oct 11, 2023

Test failure is unrelated, force merging.

@cmacknz cmacknz merged commit ef598c5 into main Oct 11, 2023
11 of 15 checks passed
@cmacknz cmacknz deleted the revert-3492-feat/start-server-when-mon-enabled branch October 11, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip skip-changelog Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants