Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESS Staging integ test improvements #3547

Merged
merged 6 commits into from
Oct 16, 2023
Merged

ESS Staging integ test improvements #3547

merged 6 commits into from
Oct 16, 2023

Conversation

pchila
Copy link
Member

@pchila pchila commented Oct 5, 2023 •
edited
Loading

What does this PR do?

  • refactor deployment creation and support aws templates
  • support tags to be assigned to integration tests stack deployments

Why is it important?

Support all 3 major CSP and tag stack deployments appropriately

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pchila pchila added skip-changelog Testing backport-v8.10.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify labels Oct 5, 2023
@pchila pchila self-assigned this Oct 5, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 5, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-13T08:33:05.718+0000

  • Duration: 28 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 6493
Skipped 59
Total 6552

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 5, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.78% (81/82) 👍
Files 67.34% (200/297) 👍
Classes 66.004% (365/553) 👍
Methods 53.453% (1161/2172) 👎 -0.074
Lines 39.703% (13535/34091) 👎 -0.048
Conditionals 100.0% (0/0) 💚

@pchila pchila force-pushed the integ-test-improvements branch from 93bf79e to 3bbbd06 Compare October 6, 2023 13:41
@pchila pchila added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 6, 2023
@pchila pchila marked this pull request as ready for review October 6, 2023 15:13
@pchila pchila requested a review from a team as a code owner October 6, 2023 15:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

cmacknz
cmacknz reviewed Oct 6, 2023
View reviewed changes
magefile.go Outdated Show resolved Hide resolved
@ycombinator
Copy link
Contributor

ycombinator commented Oct 11, 2023 •
edited
Loading

There are dev features that are exclusive to the CFT regions

I think I'm missing some background on this PR. Why are we moving from GCP to AWS in the staging environment? From what I can tell both GCP and AWS regions in staging support the same stack versions, including snapshots. What other dev features are exclusive to the AWS region in staging that aren't available in the GCP region in staging?

@pchila pchila requested a review from cmacknz October 12, 2023 14:56
@pchila
Copy link
Member Author

pchila commented Oct 12, 2023

buildkite test this

2 similar comments
@pchila
Copy link
Member Author

pchila commented Oct 13, 2023

buildkite test this

@pchila
Copy link
Member Author

pchila commented Oct 13, 2023

buildkite test this

@elastic-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pchila pchila merged commit be04fba into elastic:main Oct 16, 2023
8 checks passed
@pchila pchila deleted the integ-test-improvements branch October 16, 2023 06:48
mergify bot pushed a commit that referenced this pull request Oct 16, 2023
@pchila @mergify
ESS Staging integ test improvements (#3547)
1a80b13 
* support tags on integration tests ESS deployments

(cherry picked from commit be04fba)
mergify bot pushed a commit that referenced this pull request Oct 16, 2023
@pchila @mergify
ESS Staging integ test improvements (#3547)
6f28693 
* support tags on integration tests ESS deployments

(cherry picked from commit be04fba)
This was referenced Oct 16, 2023
Merged
Merged
pierrehilbert pushed a commit that referenced this pull request Oct 16, 2023
@mergify @pchila
ESS Staging integ test improvements (#3547) (#3605)
d5b58ef 
* support tags on integration tests ESS deployments

(cherry picked from commit be04fba)

Co-authored-by: Paolo Chilà <[email protected]>
pchila added a commit that referenced this pull request Oct 16, 2023
@mergify @pchila
ESS Staging integ test improvements (#3547) (#3604)
fda3726 
* support tags on integration tests ESS deployments

(cherry picked from commit be04fba)

Co-authored-by: Paolo Chilà <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

@blakerouse blakerouse Awaiting requested review from blakerouse

@cmacknz cmacknz Awaiting requested review from cmacknz

Assignees

@pchila pchila

Labels
backport-v8.10.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pchila @elasticmachine @ycombinator @cmacknz