-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update serverless support in integration tests, expand test tooling, add support for beats testing #3486
Update serverless support in integration tests, expand test tooling, add support for beats testing #3486
Conversation
The one Serverless test you are trying to run is actually being skipped, so it isn't testing anything.
Test report is here |
I think this was fixed on main with #3616 This test should also run on Windows and not just Linux, you can remove the OS restriction. |
Alright, so it looks like those windows tests might have been disabled for a reason, because it's failing. Want to see if it's just timing out, or if there's a deeper issue... |
how ironic
|
// set a long timeout | ||
// this context travels up to the magefile, clients that want a shorter timeout can set | ||
// it via mage's -t flag | ||
readyCtx, readyCancel := context.WithTimeout(ctx, 25*time.Minute) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the additional 10 minutes, is serverless that much slower?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually for stateful, I ran into a couple timeouts while testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did it fix the problem, or does it just wait longer before failing? Sometimes the stack can fail to come up and waiting doesn't fix it, it just makes you wait longer until finding out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, good to merge once the tests pass again. Looks like the failure was in the serverless tests this time.
Never seen that before.
|
Sigh, something seems to be breaking the resulting junit files...
|
Downloaded the XML files, they all appear to parse correctly. |
SonarQube Quality Gate 0 Bugs No Coverage information |
In typical fashion, can't reproduce the failure, which was a setup issue. I'm guessing there was some intermittent timeout or issue setting up auth against the serverless cluster. |
What does this PR do?
This PR "breaks apart" #3258 into only changes needed to support serverless instances in integration tests, as well as testing with beats, and various expansions to the tooling available to integration tests. Essentially, this is everything except the actual beats serverless tests.
Why is it important?
We want serverless testing support, and need to support #3258
Checklist
./changelog/fragments
using the changelog tool