Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove flags for policy defaulting (#226)" #282

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Revert "Remove flags for policy defaulting (#226)" #282

merged 1 commit into from
Apr 1, 2022

Conversation

ph
Copy link
Contributor

@ph ph commented Apr 1, 2022 •
edited
Loading

This reverts commit 98f47b8.

PR : #226
Fleet-server's revert: elastic/fleet-server#1287

@ph ph added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team backport-v8.2.0 backport-v8.3.0 Automated backport with mergify labels Apr 1, 2022
@ph ph requested a review from a team April 1, 2022 13:29
@ph ph self-assigned this Apr 1, 2022
@ph ph requested a review from lykkin April 1, 2022 13:30
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-01T13:30:05.981+0000

  • Duration: 17 min 26 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

narph
narph approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@narph narph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compared with initial PR, LGTM

@ph ph merged commit f8f1098 into elastic:main Apr 1, 2022
mergify bot pushed a commit that referenced this pull request Apr 1, 2022
@ph
Revert "Remove flags for policy defaulting (#226)" (#282)
b7be43e 
This reverts commit 98f47b8.

(cherry picked from commit f8f1098)
@mergify mergify bot mentioned this pull request Apr 1, 2022
Merged
ph added a commit that referenced this pull request Apr 1, 2022
@mergify @ph
Revert "Remove flags for policy defaulting (#226)" (#282) (#283)
84b1106 
This reverts commit 98f47b8.

(cherry picked from commit f8f1098)

Co-authored-by: Pier-Hugues Pellerin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narph narph narph approved these changes

@lykkin lykkin Awaiting requested review from lykkin

Assignees

@ph ph

Labels
backport-v8.2.0 backport-v8.3.0 Automated backport with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ph @elasticmachine @narph