Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional unit tests to fleet-server config #2499

Merged

Conversation

michel-laterman
Copy link
Contributor

Follow up to #2495 to add tests for additional coverage

@michel-laterman michel-laterman added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team technical debt labels Apr 13, 2023
@michel-laterman michel-laterman requested a review from a team as a code owner April 13, 2023 15:03
@michel-laterman michel-laterman requested review from michalpristas and removed request for a team April 13, 2023 15:03
@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2023

This pull request does not have a backport label. Could you fix it @michel-laterman? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-13T15:03:54.455+0000

  • Duration: 17 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 5515
Skipped 19
Total 5534

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.529% (67/68) 👍 0.022
Files 68.22% (161/236) 👎 -1.649
Classes 67.785% (303/447) 👎 -1.322
Methods 54.052% (927/1715) 👎 -0.322
Lines 39.602% (10497/26506) 👎 -0.005
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional tests!

@michel-laterman michel-laterman merged commit 0fd3447 into elastic:main Apr 13, 2023
@michel-laterman michel-laterman deleted the fleet-server-config-unit-test branch April 13, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants