Fix install on Mac OS to ensure that the /usr/local/bin exists #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakerouse
requested review from
AndersonQ and
pchila
and removed request for
a team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
...g/fragments/1681311024-Ensure-local-bin-directory-exists-on-Mac-OS-during-installation..yaml
Outdated
Show resolved
Hide resolved
ycombinator
reviewed
Apr 12, 2023
ycombinator
approved these changes
Apr 12, 2023
🌐 Coverage report
|
|
I was able to test this on freshly deployed M1 mac on AWS. Installation worked successfully, both with the |
mergify bot
pushed a commit
that referenced
this pull request
Apr 12, 2023
* Fix install on Mac OS to ensure that the /usr/local/bin exists. * Add changelog. * Fix changelog. More DRY for install. (cherry picked from commit f9bc516)
blakerouse
added a commit
that referenced
this pull request
Apr 13, 2023
#2494) * Fix install on Mac OS to ensure that the /usr/local/bin exists. * Add changelog. * Fix changelog. More DRY for install. (cherry picked from commit f9bc516) Co-authored-by: Blake Rouse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensures that the
/usr/local/bindirectory exists on Mac OS before it places the/usr/local/bin/elastic-agentsymlink.Why is it important?
On a fresh installation of Mac OS the
/usr/local/bindoesn't exist causing theinstallsubcommand to fail to complete installation.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testRelated issues