Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestManager_FakeShipper flakiness. #2483

Merged
merged 4 commits into from
Apr 13, 2023
Merged

Conversation

blakerouse
Copy link
Contributor

What does this PR do?

Removes skip on the TestManager_FakeShipper and fixes the flakiness of the test. The issue was the test didn't wait for the shippers input and output unit to be healthy before performing the sending of the event test.

Why is it important?

Ensures that testing and configuration of a component and shipper works correctly.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues

@blakerouse blakerouse requested a review from a team as a code owner April 11, 2023 15:44
@blakerouse blakerouse requested review from AndersonQ and pchila and removed request for a team April 11, 2023 15:44
@mergify
Copy link
Contributor

mergify bot commented Apr 11, 2023

This pull request does not have a backport label. Could you fix it @blakerouse? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 11, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-12T19:47:44.214+0000

  • Duration: 17 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 5455
Skipped 19
Total 5474

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 11, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.507% (66/67) 👍
Files 69.869% (160/229) 👍 0.437
Classes 69.108% (302/437) 👍 0.458
Methods 54.316% (925/1703) 👍 0.176
Lines 39.674% (10455/26352) 👍 0.338
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of nitpicks but LGTM.

@blakerouse blakerouse merged commit b58d2a7 into elastic:main Apr 13, 2023
@blakerouse blakerouse deleted the fix-2301 branch April 13, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg/component/runtime.TestManager_FakeShipper test is flaky
3 participants