Disable flaky TestManager_FakeShipper test.

[cmacknz]

This test has been flaky for a while and we haven't fixed it, so just skip it until we get it fixed. Additionally, reference "windows" consistently in the test file.

• Relates pkg/component/runtime.TestManager_FakeShipper test is flaky #2301

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-03-27T17:13:57.309+0000

• Duration: 18 min 29 sec

Test stats 🧪

Test	Results
Failed	0
Passed	5239
Skipped	23
Total	5262

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages.

• run integration tests : Run the Elastic Agent Integration tests.

• run end-to-end tests : Generate the packages and run the E2E Tests.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[cmacknz]

Apparently this test is flaky on Linux as well, removing the GOOS == Windows restriction.

[elasticmachine]

🌐 Coverage report

Name	Metrics % (covered/total)	Diff
Packages	98.438% (63/64)	👍
Files	69.863% (153/219)	👎 -0.457
Classes	68.523% (283/413)	👎 -0.484
Methods	53.994% (872/1615)	👎 -0.186
Lines	39.28% (9717/24738)	👎 -0.327
Conditionals	100.0% (0/0)	💚

[cmacknz]

Of course, this PR has now revealed that runtime.TestManager_FakeInput_OutputChange is also flaky. Going to file and issue and disable that test as well.

[cmacknz]

=== RUN   TestManager_FakeInput_OutputChange
    manager_test.go:2480: component fake-0 state changed: {State:STARTING Message:Starting: spawned pid '2136' Units:map[{UnitType:input UnitID:fake-input-0-0}:{State:STARTING Message:Starting: spawned pid '2136' Payload:map[] unitState:0 unitMessage:Starting unitPayload:map[] configStateIdx:0 err:<nil>} {UnitType:input UnitID:fake-input-0-1}:{State:STARTING Message:Starting: spawned pid '2136' Payload:map[] unitState:0 unitMessage:Starting unitPayload:map[] configStateIdx:0 err:<nil>} {UnitType:input UnitID:fake-input-0-2}:{State:STARTING Message:Starting: spawned pid '2136' Payload:map[] unitState:0 unitMessage:Starting unitPayload:map[] configStateIdx:0 err:<nil>}] VersionInfo:{Name: Version: Meta:map[]} expectedUnits:map[{UnitType:0 UnitID:fake-input-0-0}:{state:2 configStateIdx:1 config:0xc000120a20 err:<nil> logLevel:0} {UnitType:0 UnitID:fake-input-0-1}:{state:2 configStateIdx:1 config:0xc000120ab0 err:<nil> logLevel:0} {UnitType:0 UnitID:fake-input-0-2}:{state:2 configStateIdx:1 config:0xc000120b40 err:<nil> logLevel:0}]}
    manager_test.go:2480: component fake-0 state changed: {State:STOPPED Message:Stopped: pid '2136' exited with code '1' Units:map[{UnitType:input UnitID:fake-input-0-0}:{State:STOPPED Message:Stopped: pid '2136' exited with code '1' Payload:map[] unitState:0 unitMessage:Starting unitPayload:map[] configStateIdx:0 err:<nil>} {UnitType:input UnitID:fake-input-0-1}:{State:STOPPED Message:Stopped: pid '2136' exited with code '1' Payload:map[] unitState:0 unitMessage:Starting unitPayload:map[] configStateIdx:0 err:<nil>} {UnitType:input UnitID:fake-input-0-2}:{State:STOPPED Message:Stopped: pid '2136' exited with code '1' Payload:map[] unitState:0 unitMessage:Starting unitPayload:map[] configStateIdx:0 err:<nil>}] VersionInfo:{Name: Version: Meta:map[]} expectedUnits:map[{UnitType:0 UnitID:fake-input-0-0}:{state:2 configStateIdx:1 config:0xc000120a20 err:<nil> logLevel:0} {UnitType:0 UnitID:fake-input-0-1}:{state:2 configStateIdx:1 config:0xc000120ab0 err:<nil> logLevel:0} {UnitType:0 UnitID:fake-input-0-2}:{state:2 configStateIdx:1 config:0xc000120b40 err:<nil> logLevel:0}]}
    manager_test.go:2484: component fake-1 state changed: {State:STARTING Message:Starting: spawned pid '348' Units:map[{UnitType:input UnitID:fake-input-1-0}:{State:STARTING Message:Starting: spawned pid '348' Payload:map[] unitState:0 unitMessage:Starting unitPayload:map[] configStateIdx:0 err:<nil>} {UnitType:input UnitID:fake-input-1-1}:{State:STARTING Message:Starting: spawned pid '348' Payload:map[] unitState:0 unitMessage:Starting unitPayload:map[] configStateIdx:0 err:<nil>}] VersionInfo:{Name: Version: Meta:map[]} expectedUnits:map[{UnitType:0 UnitID:fake-input-1-0}:{state:2 configStateIdx:1 config:0xc000120c60 err:<nil> logLevel:0} {UnitType:0 UnitID:fake-input-1-1}:{state:2 configStateIdx:1 config:0xc000120cf0 err:<nil> logLevel:0}]}
    manager_test.go:2484: component fake-1 state changed: {State:HEALTHY Message:Healthy: communicating with pid '348' Units:map[{UnitType:input UnitID:fake-input-1-0}:{State:STARTING Message:Starting: spawned pid '348' Payload:map[] unitState:0 unitMessage: unitPayload:map[] configStateIdx:0 err:<nil>} {UnitType:input UnitID:fake-input-1-1}:{State:STARTING Message:Starting: spawned pid '348' Payload:map[] unitState:0 unitMessage: unitPayload:map[] configStateIdx:0 err:<nil>}] VersionInfo:{Name:fake Version:1.0 Meta:map[input:fake]} expectedUnits:map[{UnitType:0 UnitID:fake-input-1-0}:{state:2 configStateIdx:1 config:0xc000120c60 err:<nil> logLevel:0} {UnitType:0 UnitID:fake-input-1-1}:{state:2 configStateIdx:1 config:0xc000120cf0 err:<nil> logLevel:0}]}
    manager_test.go:2484: component fake-1 state changed: {State:HEALTHY Message:Healthy: communicating with pid '348' Units:map[{UnitType:input UnitID:fake-input-1-0}:{State:HEALTHY Message:Fake Healthy 0-0 Payload:map[] unitState:2 unitMessage:Fake Healthy 0-0 unitPayload:map[] configStateIdx:1 err:<nil>} {UnitType:input UnitID:fake-input-1-1}:{State:HEALTHY Message:Fake Healthy 0-1 Payload:map[] unitState:2 unitMessage:Fake Healthy 0-1 unitPayload:map[] configStateIdx:1 err:<nil>}] VersionInfo:{Name:fake Version:1.0 Meta:map[input:fake]} expectedUnits:map[{UnitType:0 UnitID:fake-input-1-0}:{state:2 configStateIdx:1 config:0xc000120c60 err:<nil> logLevel:0} {UnitType:0 UnitID:fake-input-1-1}:{state:2 configStateIdx:1 config:0xc000120cf0 err:<nil> logLevel:0}]}
    manager_test.go:2533: timed out after 30 seconds
--- FAIL: TestManager_FakeInput_OutputChange (34.29s)

[pchila]

I am fine with the changes in this PR but it seems that there are some other flaky tests lying around TestManager_FakeInput_OutputChange for example... Not sure if we want to address that here or if it will have its own PR anytime soon

[cmacknz]

I've also filed and issue for and disabled the TestManager_FakeInput_OutputChange in the same file.