Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the file extension in unit diagnostics again. #2270

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Add the file extension in unit diagnostics again. #2270

merged 1 commit into from
Feb 14, 2023

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Feb 14, 2023 •
edited
Loading

Re-apply the changes from #2047 again since they somehow got lost on main again.

I think this was lost during merge conflict resolution in #1703 and so this only applies to 8.7 and main

@cmacknz
Add the file extension in unit diagnostics again.
bed7418 
Re-apply the changes from
elastic#2047 again since they
somehow got lost on main again.
@cmacknz cmacknz added v8.7.0 backport-v8.7.0 Automated backport with mergify labels Feb 14, 2023
@cmacknz cmacknz requested a review from a team as a code owner February 14, 2023 18:50
@cmacknz cmacknz self-assigned this Feb 14, 2023
@cmacknz cmacknz requested review from pchila and removed request for a team February 14, 2023 18:50
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-14T18:50:23.359+0000

  • Duration: 17 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 4893
Skipped 13
Total 4906

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.361% (60/61) 👍
Files 68.75% (143/208) 👍
Classes 68.0% (272/400) 👍
Methods 53.521% (836/1562) 👍
Lines 38.828% (9151/23568) 👍 0.025
Conditionals 100.0% (0/0) 💚

jlind23
jlind23 approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmacknz cmacknz merged commit 3bb605d into elastic:main Feb 14, 2023
@cmacknz cmacknz deleted the fix-diagnostics-component-filenames-again branch February 14, 2023 19:34
@mergify mergify bot mentioned this pull request Feb 14, 2023
Merged
mergify bot pushed a commit that referenced this pull request Feb 14, 2023
@cmacknz @mergify
Add the file extension in unit diagnostics again. (#2270)
a22bce8 
Re-apply the changes from
#2047 again since they
somehow got lost on main again.

(cherry picked from commit 3bb605d)
cmacknz added a commit that referenced this pull request Feb 14, 2023
@mergify @cmacknz
Add the file extension in unit diagnostics again. (#2270) (#2271)
5afe9e2 
Re-apply the changes from
#2047 again since they
somehow got lost on main again.

(cherry picked from commit 3bb605d)

Co-authored-by: Craig MacKenzie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

@michel-laterman michel-laterman Awaiting requested review from michel-laterman

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@cmacknz cmacknz

Labels
backport-v8.7.0 Automated backport with mergify v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmacknz @elasticmachine @jlind23