-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port "Improve shutdown logs" from 8.5 back to main #1930
Conversation
(cherry picked from commit 72a4f61) Co-authored-by: Anderson Queiroz <[email protected]> (cherry picked from commit 567f9e2) # Conflicts: # NOTICE.txt # go.mod # go.sum # internal/pkg/agent/application/actions/handlers/handler_action_settings.go # internal/pkg/agent/application/upgrade/upgrade.go # internal/pkg/agent/cmd/run.go
We lost the changes in https://github.com/elastic/elastic-agent/pull/1618/files as part of the V2 merge. Bringing these changes forward from the 8.5 branch. |
} | ||
|
||
u.log.Infow("Restarting after upgrade", | ||
"new_version", release.Version(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is probably reversed, example from a recent 8.5.3 upgrade attempt
"Restarting after upgrade","new_version":"8.5.3","prev_version":"8.6.0",
🌐 Coverage report
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
(cherry picked from commit b9d8f5e)
This is an automatic backport of pull request #1627 done by Mergify.
Cherry-pick of 567f9e2 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com