Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.6](backport #1791) snapshot/downloader: fix fetching snapshot URI #1887

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 5, 2022

This is an automatic backport of pull request #1791 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

When parsing the response from the artifacts-api to get the latest
snapshot (https://artifacts-api.elastic.co/v1/search/%s-SNAPSHOT/elastic-agent)
it could happen that an entry that is not from the Elastic-Agent (like
the Elastic-Agent-Shipper) would be evaluated and it would cause the
`snapshotURI` function return an error.

This commit fixes it by iterating the whole map before returning an
error.

(cherry picked from commit 8c034dd)
@mergify mergify bot requested a review from a team as a code owner December 5, 2022 14:27
@mergify mergify bot added the backport label Dec 5, 2022
@mergify mergify bot requested review from michalpristas and blakerouse and removed request for a team December 5, 2022 14:27
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-06T22:38:41.434+0000

  • Duration: 18 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 4657
Skipped 13
Total 4670

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 5, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.333% (59/60) 👍
Files 69.082% (143/207) 👍
Classes 69.133% (271/392) 👍
Methods 53.988% (819/1517) 👍
Lines 39.169% (8866/22635) 👍
Conditionals 100.0% (0/0) 💚

@cmacknz
Copy link
Member

cmacknz commented Dec 6, 2022

/test

@cmacknz cmacknz merged commit 867c3db into 8.6 Dec 6, 2022
@cmacknz cmacknz deleted the mergify/bp/8.6/pr-1791 branch December 6, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants