Handle requests for /processes/apm-server. #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add special handling for the apm-server process ID for the /processes/$ID route as well as the /processes response body. V2 changed the process IDs used for these APIs, which has broken health checks in the cloud provisioning infrastructure. It is much faster to add a few lines of code to special case this in the agent than it is to update all of the cloud monitoring infrastructure.
cmacknz
added
Team:Elastic-Agent
cmacknz
requested review from
michalpristas and
blakerouse
and removed request for
a team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Tested locally with an agent running the APM integration. Going to merge this to try to fix the snapshot, otherwise will likely be waiting several days for a review. |
mergify bot
pushed a commit
that referenced
this pull request
Nov 24, 2022
Handle requests for /processes/apm-server. Add special handling for the apm-server process ID for the /processes/$ID route as well as the /processes response body. V2 changed the process IDs used for these APIs, which has broken health checks in the cloud provisioning infrastructure. It is much faster to add a few lines of code to special case this in the agent than it is to update all of the cloud monitoring infrastructure. (cherry picked from commit 378a412)
cmacknz
added a commit
that referenced
this pull request
Nov 24, 2022
Handle requests for /processes/apm-server. Add special handling for the apm-server process ID for the /processes/$ID route as well as the /processes response body. V2 changed the process IDs used for these APIs, which has broken health checks in the cloud provisioning infrastructure. It is much faster to add a few lines of code to special case this in the agent than it is to update all of the cloud monitoring infrastructure. (cherry picked from commit 378a412) Co-authored-by: Craig MacKenzie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add special handling for the apm-server process ID for the /processes/$ID route as well as the /processes response body.
V2 changed the process IDs used for these APIs, which has broken health checks in the cloud provisioning infrastructure. It is much faster to add a few lines of code to special case this in the agent than it is to update all of the cloud monitoring infrastructure.