Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a spec for new cloud_defend integration input #1764

Merged
merged 11 commits into from
Nov 29, 2022
Merged

Conversation

mitodrummer
Copy link
Contributor

@mitodrummer mitodrummer commented Nov 21, 2022

What does this PR do?

Creates the spec for a new executable being added for container drift prevention.

Why is it important?

A new cloud defend integration is being created by the AWP team to allow users to protect their containers.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TODO

Related issues

Logs

@mitodrummer mitodrummer added the enhancement New feature or request label Nov 21, 2022
@mitodrummer mitodrummer requested a review from lrishi November 21, 2022 16:52
@mergify
Copy link
Contributor

mergify bot commented Nov 21, 2022

This pull request does not have a backport label. Could you fix it @mitodrummer? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

Copy link

@lrishi lrishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Karl 🥇
Cc: @norrietaylor @m-sample

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 21, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-29T18:45:09.887+0000

  • Duration: 18 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 4617
Skipped 13
Total 4630

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 21, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.333% (59/60) 👍
Files 69.082% (143/207) 👍
Classes 69.133% (271/392) 👍
Methods 53.8% (814/1513) 👍
Lines 38.994% (8795/22555) 👍 0.009
Conditionals 100.0% (0/0) 💚

@mitodrummer mitodrummer marked this pull request as ready for review November 21, 2022 17:12
@mitodrummer mitodrummer requested a review from a team as a code owner November 21, 2022 17:12
@mitodrummer mitodrummer requested review from aleksmaus and michalpristas and removed request for a team November 21, 2022 17:12
Copy link
Contributor

@oren-zohar oren-zohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to add the stream like other beats do here:

@oren-zohar
Copy link
Contributor

I would also suggest following the arguments other beats pass, see here


you can ignore "filebeat.config.modules.enabled=false" in your case.

specs/cloud-defend.spec.yml Outdated Show resolved Hide resolved
@mitodrummer mitodrummer changed the title Added a spec for new cloud_defend beat. Added a spec for new cloud_defend Nov 22, 2022
@mitodrummer mitodrummer requested a review from cmacknz November 24, 2022 17:35
@mitodrummer mitodrummer requested a review from a team November 25, 2022 00:04
@mergify
Copy link
Contributor

mergify bot commented Nov 28, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b cloud_defend_spec upstream/cloud_defend_spec
git merge upstream/main
git push upstream cloud_defend_spec

@mitodrummer mitodrummer changed the title Added a spec for new cloud_defend Added a spec for new cloud_defend integration input Nov 28, 2022
@cmacknz cmacknz merged commit 86d64cf into main Nov 29, 2022
@cmacknz cmacknz deleted the cloud_defend_spec branch November 29, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants