Avoid reporting Unhealthy on fleet connectivity issues (#1152) (#1153)

Avoid reporting `Unhealthy` on fleet connectivity issues (#1152)

(cherry picked from commit d811ef3)

Co-authored-by: Michal Pristas <[email protected]>

internal/pkg/agent/application/gateway/fleet/fleet_gateway.go

@@ -291,15 +291,13 @@ func (f *fleetGateway) doExecute() (*fleetapi.CheckinResponse, error) {
 				)
 
 				f.log.Error(err)
-				f.statusReporter.Update(state.Failed, err.Error(), nil)
 				return nil, err
 			}
 			if f.checkinFailCounter > 1 {
-				// Update status reporter for gateway to degraded when there are two consecutive failures.
-				// Note that this may not propagate to fleet-server as the agent is having issues checking in.
-				// It may also (falsely) report a degraded session for 30s if it is eventually successful.
-				// However this component will allow the agent to report fleet gateway degredation locally.
-				f.statusReporter.Update(state.Degraded, fmt.Sprintf("checkin failed: %v", err), nil)
+				// do not update status reporter with failure
+				// status reporter would report connection failure on first successful connection, leading to
+				// stale result for certain period causing slight confusion.
+				f.log.Errorf("checking number %d failed: %s", f.checkinFailCounter, err.Error())
 			}
 			continue
 		}

internal/pkg/agent/application/gateway/fleet/fleet_gateway_test.go

@@ -25,7 +25,6 @@ import (
 	"github.com/elastic/elastic-agent/internal/pkg/agent/application/paths"
 	"github.com/elastic/elastic-agent/internal/pkg/agent/storage"
 	"github.com/elastic/elastic-agent/internal/pkg/agent/storage/store"
-	"github.com/elastic/elastic-agent/internal/pkg/core/state"
 	"github.com/elastic/elastic-agent/internal/pkg/fleetapi"
 	noopacker "github.com/elastic/elastic-agent/internal/pkg/fleetapi/acker/noop"
 	"github.com/elastic/elastic-agent/internal/pkg/scheduler"
@@ -705,7 +704,6 @@ func TestRetriesOnFailures(t *testing.T) {
 		queue.On("Actions").Return([]fleetapi.Action{})
 
 		fleetReporter := &testutils.MockReporter{}
-		fleetReporter.On("Update", state.Degraded, mock.Anything, mock.Anything).Times(2)
 		fleetReporter.On("Update", mock.Anything, mock.Anything, mock.Anything).Maybe()
 		fleetReporter.On("Unregister").Maybe()