Add linting rules for replace directives in go.mod (#2638) (#2698)

* Add linting rules for `replace` directives in go.mod

* Adding test replace dependencies

* Commenting out local replace

* Run go mod tidy

* Enable the linter

* Add back both test examples

* Removing local example

* Trying out nolint

* Trying again

* Trying another way

* Removing test replace directive

(cherry picked from commit 3aeb206)

Co-authored-by: Shaunak Kashyap <[email protected]>

.golangci.yml

@@ -55,6 +55,7 @@ linters:
     - unconvert # Remove unnecessary type conversions
     - wastedassign # wastedassign finds wasted assignment statements.
     - gomodguard # check for blocked dependencies
+    - gomoddirectives
 
 # all available settings of specific linters
 linters-settings:
@@ -99,6 +100,20 @@ linters-settings:
               - fmt
             reason: "This package is deprecated, use `fmt.Errorf` with `%w` instead"
 
+  gomoddirectives:
+    # Forbid local `replace` directives
+    replace-local: false
+
+    # Forbid any `replace` directives that are intended temporarily only during
+    # development. The modules listed below are intended to be replaced permanently.
+    replace-allow-list:
+      - github.com/Microsoft/go-winio
+      - github.com/Shopify/sarama
+      - github.com/dop251/goja
+      - github.com/dop251/goja_nodejs
+      - github.com/fsnotify/fsnotify
+      - github.com/tonistiigi/fifo
+
   gosimple:
     # Select the Go version to target. The default is '1.13'.
     go: "1.19.9"