Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system/process fixes on AIX #61

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

djboris9
Copy link
Contributor

@djboris9 djboris9 commented Nov 8, 2022

To be labelled:

  • Bug
  • Enhancement

What does this PR do?

It makes system/process usable on AIX. The preparation of this package for AIX was already done but in it's current state it's not usable for metricbeat.

The following things were done:

  • GetPIDState was implemented for AIX as currently it was returning a "not implemented" from psutils
  • Function procExists was implemented as the usage of GetInfoForPid isn't suitable to detect if a process still exists and can lead to errors. For example metricbeat couldn't handle lock files on AIX. Usage of getprocs on AIX possibly wrong #60
  • A bug was fixed where in special cases (e.g. pid 0) no exe is parsable from cmdargs which caused out of range errors
  • system/process tests were activated on AIX

Why is it important?

metricbeat is mostly prepared for AIX but it isn't completely working because of bugs like this or lacking features like #58
This PR ensures that a current metricbeat version is still buildable and usable on AIX.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Author's Checklist

Related issues

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 8, 2022

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-08T06:41:55.763+0000

  • Duration: 3 min 38 sec

Steps errors 2

Expand to view the steps failures

Load a resource file from a library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/elastic-agent-system-metrics.yml
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/djboris9 return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/djboris9 : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/djboris9 : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@djboris9 djboris9 marked this pull request as ready for review November 8, 2022 06:42
@djboris9 djboris9 requested a review from a team as a code owner November 8, 2022 06:42
@djboris9 djboris9 requested review from cmacknz and leehinman and removed request for a team November 8, 2022 06:42
@leehinman leehinman removed their request for review August 21, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of getprocs on AIX possibly wrong
2 participants