metric/system/cgroup: introduce cache for cgroup v2 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianl
added
enhancement
florianl
requested review from
ycombinator and
rdner
and removed request for
a team
leehinman
approved these changes
Nov 27, 2023
belimawr
approved these changes
Nov 28, 2023
florianl
force-pushed
the
flo-revert-#113
branch
from
b7e4327 to
2498acd
Compare
Signed-off-by: Florian Lehner <[email protected]>
florianl
force-pushed
the
flo-revert-#113
branch
2 times, most recently
from
f4c21aa to
dcf15d6
Compare
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
florianl
force-pushed
the
flo-revert-#113
branch
from
dcf15d6 to
204546d
Compare
|
sorry - but making linter happy seems to be impossible ... |
|
@cmacknz should we just force merge this one? |
|
If the linter is the only problem we can force merge this, at least for me the linter is not even a blocking step (the squash and merge button is available) so there is no force merge required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reintroduce the improvements from #103. This PR got reverted with #113 because of #109. The issue, that got reported in #109, was fixed with #116.
So its time to bring back the performance improvements by reintroducing the cache for cgroup v2.
Why is it important?
Checklist
I have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.md