Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics from /proc/[pid]/io to system/process metrics on linux #114

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

fearful-symmetry
Copy link
Contributor

What does this PR do?

Part of elastic/beats#7461

This ended up being fairly simple; we just fetch per-process IO from procfs, and these values appear to be largely identical to what's reported by the netlink taskstat.

This just reads metrics from /proc/[pid]/io and reports them as part of other process metrics, same as how things like memory usage are reported.

Why is it important?

We want per-process I/O metrics.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

@fearful-symmetry fearful-symmetry added the Team:Elastic-Agent Label for the Agent team label Nov 16, 2023
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner November 16, 2023 18:21
@fearful-symmetry fearful-symmetry self-assigned this Nov 16, 2023
@fearful-symmetry fearful-symmetry requested review from ycombinator and rdner and removed request for a team November 16, 2023 18:21
@fearful-symmetry fearful-symmetry merged commit a9ca78c into elastic:main Nov 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants