Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set Go version in CI #58

Merged
merged 3 commits into from
Jun 7, 2022
Merged

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Jun 6, 2022

Don't unconditionally build with Go version 1.18.2 by reading the Go version to use from the .go-version file. Also make sure the notice file is regenerated so mage check will detect when someone added a dependency but didn't update the license file.

Port changes from elastic/elastic-agent-shipper#45

cmacknz added 2 commits June 6, 2022 17:03
Also make sure the notice file is up to date.
@cmacknz cmacknz added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 6, 2022
@cmacknz cmacknz requested a review from a team as a code owner June 6, 2022 21:04
@cmacknz cmacknz requested review from belimawr and kvch and removed request for a team June 6, 2022 21:04
@cmacknz cmacknz self-assigned this Jun 6, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-06T21:24:57.280+0000

  • Duration: 9 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 1067
Skipped 6
Total 1073

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@cmacknz cmacknz merged commit 718cb6f into elastic:main Jun 7, 2022
@cmacknz cmacknz deleted the fix-go-version-in-ci branch June 7, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants