[windows] - Introduce PdhGetRawCounterArrayW #254
Conversation
VihasMakwana
requested review from
mauri870 and
khushijain21
and removed request for
a team
VihasMakwana
added
the
Team:Elastic-Agent-Data-Plane
VihasMakwana
changed the title
| ret := make([]PdhRawCounterItem, 0, len(items)) | ||
| for _, item := range items { | ||
| instance := windows.UTF16PtrToString(item.SzName) | ||
| if filterTotal && strings.Contains(instance, "_Total") { |
There was a problem hiding this comment.
Do we have to worry if this is a non-English Windows system? Just wondering if we might have something besides "_Total".
There was a problem hiding this comment.
For instance name? Nope. The name remains _Total.
I did a quick test on windows VM by changing language to Spanish.
For counter name? yes, the language makes a lot of change.
Hence, I've updated the AddCounter function in this PR. PTAL!
There was a problem hiding this comment.
Do we have to worry if this is a non-English Windows system? Just wondering if we might have something besides "_Total".
For this specific piece of code? Nope.
| h, err = PdhAddEnglishCounter(q.Handle, counterPath, 0) | ||
| } else { | ||
| h, err = PdhAddCounter(q.Handle, counterPath, 0) | ||
| } |
There was a problem hiding this comment.
@leehinman These are two different API calls.
PdhAddCounter is language specific.
PdhAddEnglishCounter is language neutral.
💚 Build Succeeded
History
|
|
@mauri870 can you take a look when you have a moment? You left some comments :) |
Thanks, I have looked at it again and codewise it looks good to me. I'm not too familiar with windows but the usage here seems correct. |
While performing benchmarking, I noticed that by using https://learn.microsoft.com/en-us/windows/win32/api/pdh/nf-pdh-pdhgetrawcounterarrayw we can achieve faster results with reduced memory usage.
This PR adds the methods for PdhGetRawCounterArrayW function.
It also does following thing to improve memory benchmarks:
n+1instance names corresponding tonCPU cores.Processor Information(0)/ % Idle Timerefers to the idle time spent by CPU core0Processor Information(1)/ % Idle Timerefers to the idle time spent by CPU core1Processor Information(n)/ % Idle Timerefers to the idle time spent by CPU corenProcessor Information(_Total)/ % Idle Timerefers to the average idle time spent for all CPUs.