certutil: certificates are valid for 30 days and cli improvements #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonQ
requested review from
faec and
VihasMakwana
and removed request for
a team
AndersonQ
added
Team:Elastic-Agent-Data-Plane
1 task
pierrehilbert
requested review from
mauri870
and removed request for
faec and
VihasMakwana
AndersonQ
force-pushed
the
improve-certutil
branch
from
749b12d to
0722850
Compare
- the generated certificates are valid for 30 days instead of 7 - add `-noip` flag to allow generating certificates without ips - restore the `-rsa` flag - add `-names` flag to allow setting multiple dns names - add `-client` flag to generate a certificate without any SAN/DNS or IP
AndersonQ
force-pushed
the
improve-certutil
branch
from
0722850 to
91aa43d
Compare
💚 Build Succeeded
History
cc @AndersonQ |
mauri870
changed the title
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
-noipflag to allow generating certificates without ips-rsaflag-namesflag to allow setting multiple dns names-clientflag to generate a certificate without any SAN/DNS or IPWhy is it important?
useful for generating certificates for test
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have added tests that prove my fix is effective or that my feature worksRelated issues