Fix closerCore With behaviour #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the behaviour of `closerCore.With` and add tests to ensure it works as expected. The tests are a modification of existing tests that calls the configuration functions like Beats does and ensures both closerCore and typedCore are used. The method calls get proxyed from one core to another, so both are tested together.
belimawr
requested review from
rdner,
fearful-symmetry and
leehinman
and removed request for
a team
Close all loggers so the temporary folders can be removed on Windows. All lint warnings are also fixed
Disable the race detector on Windows and remove the race bug introduced to test the CI execution of the race detector.
💚 Build Succeeded
History
cc @belimawr |
This was referenced May 30, 2024
ycombinator
added
the
Team:Elastic-Agent-Data-Plane
leehinman
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit fixes the behaviour of
closerCore.WithwhenWithis called or selective debug logging is used. It also adds tests to ensure it works as expected.The tests are a modification of existing tests that calls the configuration functions like Beats does and ensures both closerCore and typedCore are used. The method calls get proxyed from one core to another, so both are tested together.
The race detector is also enabled on Linux and Mac. For Windows it requires CGO and the installation of GCC on the host, hence it's not enabled on this PR.
Why is it important?
It fixes some bugs introduced by #205
Checklist
## Author's Checklist## Related issues