Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] windows service, receive multiple change requests #155

Merged

Conversation

leehinman
Copy link
Contributor

What does this PR do?

In the windows service Execute function, use for loop to receive all the change requests not just the first one.

Why is it important?

Without this only the first change request is received. So if the service is sent Interrogate, followed by Shutdown, it would only see the Interrogate request and never receive the Shutdown request.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Author's Checklist

  • [ ]

Related issues

- use for loop to receive all the change requests not just the first
  one.
@leehinman leehinman requested a review from a team as a code owner October 18, 2023 19:30
@leehinman leehinman requested review from ycombinator and faec and removed request for a team October 18, 2023 19:30
@leehinman leehinman added bug Something isn't working Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Oct 18, 2023
Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@cmacknz
Copy link
Member

cmacknz commented Oct 18, 2023

Both Beats and Agent will need this fix.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants