Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add idle_connection_timeout to HTTPTransportSettings #151

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

leehinman
Copy link
Contributor

What does this PR do?

Add idle_connection_timeout to HTTPTransportSettings

Why is it important?

Will allow users of the library that use

	Transport httpcommon.HTTPTransportSettings `config:",inline"`

in their config objects to set the keep alive setting of IdleConnTimeout by setting idle_connection_timeout

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
    ~~- [ ] I have added an entry in CHANGELOG.md ~~

Related issues

@leehinman leehinman added enhancement New feature or request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Sep 19, 2023
@leehinman leehinman requested a review from a team as a code owner September 19, 2023 19:17
@leehinman leehinman requested review from fearful-symmetry and faec and removed request for a team September 19, 2023 19:17
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and test changes LGTM. Will any user-facing documentation (probably not in this repo) need to be updated to mention the newly-available idle_connection_timeout setting under the ES output?

@leehinman
Copy link
Contributor Author

Will any user-facing documentation (probably not in this repo) need to be updated to mention the newly-available idle_connection_timeout setting under the ES output?

Yep, that will be part of the PR in the beats repo.

@leehinman leehinman merged commit 4aa204b into elastic:main Sep 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants