Add checks for serverless support #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
requested review from
rdner and
faec
and removed request for
a team
💚 Build Succeeded
|
6 tasks
faec
approved these changes
Sep 13, 2023
cmacknz
reviewed
Sep 14, 2023
| // Right now we don't have an API to tell us if we're running against serverless or not, so this actual implementation is something of a hack. | ||
| // see https://github.com/elastic/kibana/pull/164850 | ||
| func (client *Client) KibanaIsServerless() (bool, error) { | ||
| ret, _, err := client.Connection.Request("GET", "/api/saved_objects/_find", nil, nil, nil) |
There was a problem hiding this comment.
If Kibana changes this, which is entirely possible because saved objects are one of the major APIs, then this might give us the wrong result at some point. Hopefully we can catch that in the snapshot builds before release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of https://github.com/elastic/ingest-dev/issues/2176
and needed by elastic/elastic-agent#3258
This adds a
KibanaIsServerless()method to the kibana client, and also adds a header check toImportMultiPartFormFile()`, as the underlying saved objects API requires a special header when used under serverlessWhy is it important?
Needed for serverless support.
Checklist
CHANGELOG.md