Update tools and fix CI #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
fix/ci
branch
2 times, most recently
from
24f7ff7 to
4753d60
Compare
ycombinator
added
the
Team:Elastic-Agent-Data-Plane
Comment on lines
-92
to
-94
| nakedret: | ||
| # make an issue if func has more lines of code than this setting and it has naked returns; default is 30 | ||
| max-func-lines: 0 |
There was a problem hiding this comment.
nakedret is a linting check in both the elastic-agent and beats repos. To keep coding standards consistent across repos, perhaps it should be kept here as well and added to the enabled checks?
There was a problem hiding this comment.
To be clear, it is still enabled here. What this section does is set it to error for any function with a naked return. Removing it keeps it enabled, but at default configuration, which only applies to functions longer than 30 lines.
And yeah, imo we should do this everywhere. We recently did in elastic agent (elastic/elastic-agent#5442).
AndersonQ
requested changes
Oct 1, 2024
mauri870
reviewed
Oct 1, 2024
AndersonQ
approved these changes
Oct 2, 2024
mauri870
approved these changes
Oct 2, 2024
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update github.com/elastic/elastic-agent-libs so we get a more recent version of golangci-lint locally. Now running
mage lintgives the same result as the Github Action.Fix linter errors in existing code, drop deprecated linters, and revert the
nakedretlinter to its default config.I've also updated the default Go version to 1.22.7, as the updated tooling requires it.