Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker dependency #100

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Conversation

michalpristas
Copy link
Contributor

Updated dependency is needed for agent.
Replaced deprecated type type.ContainerListOptions with container.ListOptions

@jlind23
Copy link
Contributor

jlind23 commented Jul 22, 2024

@pazone the build is failing as the Windows VM are using 1.20 whereas they should now be using Go 1.21, could you please help us out here?
cc @rowlandgeoff

@ycombinator
Copy link
Contributor

@michalpristas Looks like this PR would close out #91?

@rowlandgeoff
Copy link

Looks like the Go version is specified here: https://github.com/elastic/elastic-agent-autodiscover/blob/main/.buildkite/pipeline.yml#L5

Updating that is probably the quickest fix, though I think that we try to preinstall Go on most of the images as well (possibly a future improvement to look at).

@jlind23
Copy link
Contributor

jlind23 commented Jul 22, 2024

Thanks @rowlandgeoff, I'll try to bump it here - #101

@ycombinator ycombinator added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jul 22, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @michalpristas

@michalpristas michalpristas merged commit 5eaebed into elastic:main Jul 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants