Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Threat intelligence #986

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Conversation

shimonmodi
Copy link
Contributor

@shimonmodi shimonmodi commented Sep 29, 2020

Stage 0 submission for threat intelligence

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process?
  • If submitting code/script changes, have you verified all tests pass locally using make test?
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes?
  • Is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • Have you added an entry to the CHANGELOG.next.md?

Markdown preview of this RFC

Stage 0 submission for threat intelligence
@webmat webmat added the RFC label Sep 30, 2020
@webmat webmat changed the title 0000-threat-intel.md [RFC] Threat intelligence Sep 30, 2020
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening @shimonmodi!

I've added a few minor review comments, but I think overall this looks good to advance to stage 0.

rfcs/0000-threat-intel.md Outdated Show resolved Hide resolved
rfcs/0000-threat-intel.md Outdated Show resolved Hide resolved
rfcs/0000-threat-intel.md Outdated Show resolved Hide resolved
@SHolzhauer
Copy link

See #1023 for a proposal on how to map IOC fields specifically.

ebeahan
ebeahan previously approved these changes Oct 15, 2020
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shimonmodi for making those changes! I'll assign the RFC # and merge the PR to advance to stage 0.

@ebeahan ebeahan merged commit 20ebe35 into elastic:master Oct 15, 2020
@webmat
Copy link
Contributor

webmat commented Oct 16, 2020

Thanks @ebeahan and @shimonmodi 👍

Next step Shimon is simply to open a new PR for stage 1. You can start very quick by just changing "stage 0" to "stage 1" at the top of the doc, open the PR right away with only this change, and mark it as a draft.

Then you can work on the content of the stage 1 doc as time allows and push to that PR over time.

Opening the stage 1 quickly will give us a place to drop any further feedback and ideas on this, in the meantime.

@shimonmodi
Copy link
Contributor Author

@webmat - thanks for the next steps. I just completed them.

@dainperkins
Copy link
Contributor

Question on the excel sheet mappings - is it necessary to nest e.g. file, host, user, process, etc. under threat - or would it make more sense to use the top level fields in combination with the threat fields to make the overall document naming simpler?

@webmat
Copy link
Contributor

webmat commented Oct 20, 2020

@dainperkins Discussion about this should continue on the next stage PR, here #1037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants