Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added http.forwarded_for #874 #880

Closed
wants to merge 2 commits into from
Closed

added http.forwarded_for #874 #880

wants to merge 2 commits into from

Conversation

dainok
Copy link

@dainok dainok commented Jun 28, 2020

Added http.forwarded_for for HTTP X-Forwarded-For header. See #874

@andrewstucki
Copy link
Contributor

Not that I see a need to necessarily introduce them, but wonder why the singling out of X-Forwarded-For? If we wanted to introduce defacto standard proxy header support shouldn't we add X-Forwarded-Host and X-Forwarded-Proto at the same time?

@dainok
Copy link
Author

dainok commented Jul 3, 2020

@andrewstucki you're right, here the additional fields.

@webmat
Copy link
Contributor

webmat commented Jul 20, 2020

Thanks for submitting this, @dainok! I agree we need to address the need for these HTTP headers in ECS.

I think we should focus on adding support for all HTTP headers, rather than the X-Forwarded family however. This has been discussed here #554 in the past but the discussion petered out at the time.

We'll see if we can get some attention to that.

@dainok
Copy link
Author

dainok commented Jul 21, 2020

@webmat Ok, let me know if I can do more. Close the PR if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants