Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove guidance to lowercase http.request.method #840

Merged
merged 4 commits into from
May 8, 2020
Merged

Remove guidance to lowercase http.request.method #840

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3929f0
Remove guidance to lowercase http.request.method
leehinman May 7, 2020
d77ce32
Add history to guidance
leehinman May 7, 2020
7d759cb
update generated files
leehinman May 7, 2020
bd4a7e3
Modify language in CHANGELOG entry
leehinman May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Thanks, you're awesome :-) -->

#### Deprecated

* Remove guidance to lowercase `http.request.method` #840
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Remove guidance to lowercase `http.request.method` #840
* Deprecate guidance to lowercase `http.request.method` #840

Sorry last lil change 😬


### Tooling and Artifact Changes

Expand Down
13 changes: 10 additions & 3 deletions schemas/http.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,16 @@
description: >
HTTP request method.

The field value must be normalized to lowercase for querying. See
the documentation section "Implementing ECS".
example: get, post, put
Prior to ECS 1.6.0 the following guidance was provided:

The field value must be normalized to lowercase for
querying. See the documentation section "Implementing ECS".

As of ECS 1.6.0, the guidance is deprecated because the
original case of the method may be useful in anomaly
detection. Original case will be mandated in ECS 2.0.0
webmat marked this conversation as resolved.
Show resolved Hide resolved

example: get, POST, Put
webmat marked this conversation as resolved.
Show resolved Hide resolved
webmat marked this conversation as resolved.
Show resolved Hide resolved

- name: request.body.content
level: extended
Expand Down