Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove guidance to lowercase http.request.method #840

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Thanks, you're awesome :-) -->

#### Deprecated

* Deprecate guidance to lowercase `http.request.method` #840

### Tooling and Artifact Changes

Expand Down
7 changes: 5 additions & 2 deletions code/go/ecs/http.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions docs/field-details.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -2824,13 +2824,17 @@ example: `1437`
| http.request.method
| HTTP request method.

The field value must be normalized to lowercase for querying. See the documentation section "Implementing ECS".
Prior to ECS 1.6.0 the following guidance was provided:

"The field value must be normalized to lowercase for querying."

As of ECS 1.6.0, the guidance is deprecated because the original case of the method may be useful in anomaly detection. Original case will be mandated in ECS 2.0.0

type: keyword



example: `get, post, put`
example: `GET, POST, PUT, PoST`

| extended

Expand Down
11 changes: 8 additions & 3 deletions generated/beats/fields.ecs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2273,9 +2273,14 @@
ignore_above: 1024
description: 'HTTP request method.

The field value must be normalized to lowercase for querying. See the documentation
section "Implementing ECS".'
example: get, post, put
Prior to ECS 1.6.0 the following guidance was provided:

"The field value must be normalized to lowercase for querying."

As of ECS 1.6.0, the guidance is deprecated because the original case of the
method may be useful in anomaly detection. Original case will be mandated
in ECS 2.0.0'
example: GET, POST, PUT, PoST
- name: request.referrer
level: extended
type: keyword
Expand Down
2 changes: 1 addition & 1 deletion generated/csv/fields.csv
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ ECS_Version,Indexed,Field_Set,Field,Type,Level,Normalization,Example,Description
1.6.0-dev,true,http,http.request.body.content,keyword,extended,,Hello world,The full HTTP request body.
1.6.0-dev,true,http,http.request.body.content.text,text,extended,,Hello world,The full HTTP request body.
1.6.0-dev,true,http,http.request.bytes,long,extended,,1437,Total size in bytes of the request (body and headers).
1.6.0-dev,true,http,http.request.method,keyword,extended,,"get, post, put",HTTP request method.
1.6.0-dev,true,http,http.request.method,keyword,extended,,"GET, POST, PUT, PoST",HTTP request method.
1.6.0-dev,true,http,http.request.referrer,keyword,extended,,https://blog.example.com/,Referrer for this HTTP request.
1.6.0-dev,true,http,http.response.body.bytes,long,extended,,887,Size in bytes of the response body.
1.6.0-dev,true,http,http.response.body.content,keyword,extended,,Hello world,The full HTTP response body.
Expand Down
10 changes: 7 additions & 3 deletions generated/ecs/ecs_flat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3632,9 +3632,13 @@ http.request.method:
dashed_name: http-request-method
description: 'HTTP request method.

The field value must be normalized to lowercase for querying. See the documentation
section "Implementing ECS".'
example: get, post, put
Prior to ECS 1.6.0 the following guidance was provided:

"The field value must be normalized to lowercase for querying."

As of ECS 1.6.0, the guidance is deprecated because the original case of the method
may be useful in anomaly detection. Original case will be mandated in ECS 2.0.0'
example: GET, POST, PUT, PoST
flat_name: http.request.method
ignore_above: 1024
level: extended
Expand Down
11 changes: 8 additions & 3 deletions generated/ecs/ecs_nested.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4236,9 +4236,14 @@ http:
dashed_name: http-request-method
description: 'HTTP request method.

The field value must be normalized to lowercase for querying. See the documentation
section "Implementing ECS".'
example: get, post, put
Prior to ECS 1.6.0 the following guidance was provided:

"The field value must be normalized to lowercase for querying."

As of ECS 1.6.0, the guidance is deprecated because the original case of the
method may be useful in anomaly detection. Original case will be mandated
in ECS 2.0.0'
example: GET, POST, PUT, PoST
flat_name: http.request.method
ignore_above: 1024
level: extended
Expand Down
13 changes: 10 additions & 3 deletions schemas/http.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,16 @@
description: >
HTTP request method.

The field value must be normalized to lowercase for querying. See
the documentation section "Implementing ECS".
example: get, post, put
Prior to ECS 1.6.0 the following guidance was provided:

"The field value must be normalized to lowercase for
querying."

As of ECS 1.6.0, the guidance is deprecated because the
original case of the method may be useful in anomaly
detection. Original case will be mandated in ECS 2.0.0

example: GET, POST, PUT, PoST

- name: request.body.content
level: extended
Expand Down