[DOCS] Removes incorrect nested datatype definition
#827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes an incorrect definition of the [`nested` field datatype][0]. An [`object` datatype][1], which is used by the Elastic Common Schema, can also contain an array of objects as a value. The primary difference between the `object` and `nested` datatypes is that objects in a `nested `datatype can be queried independently. However, that distinction isn't needed or relevant here. [0]: https://www.elastic.co/guide/en/elasticsearch/reference/master/nested.html [1]: https://www.elastic.co/guide/en/elasticsearch/reference/master/object.html
|
Thank you for opening this. Would you mind completely removing the line instead? There's nothing inherently wrong with the nested data type, we may very well end up using it. So this statement is irrelevant. |
|
We will should backport this to 1.5, which is the current version of the docs. Not sure it's worth backporting to all past versions, though. |
|
I can take care of the backport |
|
Thanks @webmat! |
webmat
pushed a commit
to webmat/ecs
that referenced
this pull request
Apr 24, 2020
Removes an incorrect definition of the [`nested` field datatype][0]. An [`object` datatype][1], which is used by the Elastic Common Schema, can also contain an array of objects as a value. The primary difference between the `object` and `nested` datatypes is that objects in a `nested `datatype can be queried independently. However, that distinction isn't needed or relevant here. [0]: https://www.elastic.co/guide/en/elasticsearch/reference/master/nested.html [1]: https://www.elastic.co/guide/en/elasticsearch/reference/master/object.html
This was referenced Apr 24, 2020
webmat
pushed a commit
that referenced
this pull request
Apr 24, 2020
Removes an incorrect definition of the [`nested` field datatype][0]. An [`object` datatype][1], which is used by the Elastic Common Schema, can also contain an array of objects as a value. The primary difference between the `object` and `nested` datatypes is that objects in a `nested `datatype can be queried independently. However, that distinction isn't needed or relevant here. [0]: https://www.elastic.co/guide/en/elasticsearch/reference/master/nested.html [1]: https://www.elastic.co/guide/en/elasticsearch/reference/master/object.html Co-authored-by: James Rodewig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes an incorrect definition of the
nestedfield datatype.An
objectdatatype, which is used by the Elastic Common Schema,can also contain an array of objects as a value.
The primary difference between the
objectandnesteddatatypes isthat objects in a
nesteddatatype can be queried independently.However, that distinction isn't needed or relevant here.
Closes #826