Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize additional cloud metadata #816

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Conversation

graphaelli
Copy link
Member

Adds:

  • account.name
  • project.id
  • project.name

@graphaelli graphaelli requested a review from simitt April 20, 2020 17:02
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense to me, thanks @graphaelli! Do you know if this has impact on some of the infra UIs?

I'd also like to get the opinion from someone familiar with the collection of this cloud meta-data in Beats. @urso could you plz loop in the best person to chime in on this?

@graphaelli
Copy link
Member Author

This does not impact Infra UIs - project.id is already supplied by the add_cloud_metadata processor in beats, account.id is supplied the metricbeat aws module, project.name is new.

@urso
Copy link

urso commented Apr 21, 2020

+1 on adding project/account information to the cloud namespace.

@kvch @kaiyan-sheng @narph You've been working with Cloud (AWS, Azure, GCP) to some extend. Any other meta-data in mind we would like to add?

@webmat
Copy link
Contributor

webmat commented Apr 21, 2020

Thanks @urso. What I'm looking for here is actually any concerns from getting this data from people that know about the implementation of the meta data collector in Beats.

Although if additional fields could be useful, additional PRs are always welcome :-)

@webmat webmat self-requested a review April 21, 2020 17:37
@kvch
Copy link

kvch commented Apr 22, 2020

@webmat It would be great to have appropriate field names for such services. For example, I use resource.* fields to identify and describe the states of the AWS/GCP resources from the event. But I understand, it is outside of the scope of this PR.

@webmat
Copy link
Contributor

webmat commented Apr 22, 2020

@urso @kvch Thanks for the feedback. So there's no issues in getting this information from the metadata collector?

@urso
Copy link

urso commented Apr 23, 2020

I don't think so.

Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphaelli could you add a changelog entry, we'll merge after that.

@webmat
Copy link
Contributor

webmat commented Apr 23, 2020

Oh wait, getting carried away. Did you want to wait on @simitt's review before I merge, Gil?

@graphaelli graphaelli removed the request for review from simitt April 23, 2020 14:45
@graphaelli
Copy link
Member Author

@webmat Changelog pushed, @simitt is on board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants