-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize additional cloud metadata #816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes a lot of sense to me, thanks @graphaelli! Do you know if this has impact on some of the infra UIs?
I'd also like to get the opinion from someone familiar with the collection of this cloud meta-data in Beats. @urso could you plz loop in the best person to chime in on this?
This does not impact Infra UIs - |
+1 on adding project/account information to the cloud namespace. @kvch @kaiyan-sheng @narph You've been working with Cloud (AWS, Azure, GCP) to some extend. Any other meta-data in mind we would like to add? |
Thanks @urso. What I'm looking for here is actually any concerns from getting this data from people that know about the implementation of the meta data collector in Beats. Although if additional fields could be useful, additional PRs are always welcome :-) |
@webmat It would be great to have appropriate field names for such services. For example, I use |
I don't think so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@graphaelli could you add a changelog entry, we'll merge after that.
Oh wait, getting carried away. Did you want to wait on @simitt's review before I merge, Gil? |
Adds: