Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote the labels example, to avoid the YAML interpreter interpreting it #782

Merged
merged 2 commits into from
Mar 11, 2020

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Mar 11, 2020

No description provided.

@webmat
Copy link
Contributor Author

webmat commented Mar 11, 2020

I don't think this warrants a patch release.

I suggest you replace the problem section of the 1.5 YML in Beats with this exact output (https://github.com/elastic/ecs/pull/782/files#diff-5c26e320ef5dca7ad0441c5eeb32dba3R33), @adriansr. This will avoid an unnecessary diff when comes time to introduce 1.6 in Beats. WDYT?

@webmat webmat changed the title Quote the labels example, to avoid the YAML interpreter interpret it. Quote the labels example, to avoid the YAML interpreter interpreting it Mar 11, 2020
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for patching! I will update on the beats side with the same change

@webmat webmat merged commit 2657c72 into elastic:master Mar 11, 2020
dcode pushed a commit to dcode/ecs that referenced this pull request Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants