Merge reusable location lists when merging schemas #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmat
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
This is works well, thanks for submitting this, @marshallmain! I'll merge as is.
In trying it out, I've noticed an undesirable behaviour that comes from before this PR. When creating a custom schema, and trying to nest hash under it, I found that I had to redefine things I had no intention to change in the custom "hash.yml" field set I used, in order to nest it under my custom schema.
We could eventually change at which point a field set is being validated, to improve on this. Hit me up if you're interested in looking into this ;-)
dcode
pushed a commit
to dcode/ecs
that referenced
this pull request
Apr 15, 2020
6 tasks
webmat
pushed a commit
to webmat/ecs
that referenced
this pull request
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR further enhances the generator's custom schema capabilities. It allows custom schemas to extend the list of locations that a set of official ECS fields is are reused at. For example,
hashis a fieldset that would often be useful to include in custom schemas. With this PR, users can define a custom schema file with name: hash and add more locations wherehashshould be reused in their custom schema.